wurzel/fruitbasket
9
1
Fork 0
Code Issues 5 Pull requests Packages Projects Releases Wiki Activity

mail: Enable the listescape plugin #66

Merged
hw0lff merged 2 commits from mail-listescape into main 2023-09-17 17:13:05 +02:00
Conversation 3 Commits 2 Files changed 1 +52 -48
hw0lff commented 2023-09-17 16:58:36 +02:00 (Migrated from github.com)
Copy link

Make it possible to use special characters like . in mail directories.

Please look for the correct generation of the config file.
I suspect that there might be a forrmatting error unrelated to my changes.
This is the block: 7ba1281909/modules/mail/default.nix (L203-L206)

Make it possible to use special characters like `.` in mail directories. Please look for the correct generation of the config file. I suspect that there might be a forrmatting error unrelated to my changes. This is the block: https://github.com/fsr/fruitbasket/blob/7ba1281909eb5ec160d386b3b6abbb9d0b264336/modules/mail/default.nix#L203-L206
hw0lff commented 2023-09-17 17:00:50 +02:00 (Migrated from github.com)
Copy link

I just looked at the generated etc/dovecot/dovecot.conf the whole block of extraConfig seems to be miss-formatted.

I just looked at the generated `etc/dovecot/dovecot.conf` the whole block of `extraConfig` seems to be miss-formatted.
rouven0 commented 2023-09-17 17:07:50 +02:00 (Migrated from github.com)
Copy link

I just looked at the generated etc/dovecot/dovecot.conf the whole block of extraConfig seems to be miss-formatted.

Yep, the vim installation on the machine itself is apparently misconfigured 😵‍💫

> I just looked at the generated `etc/dovecot/dovecot.conf` the whole block of `extraConfig` seems to be miss-formatted. Yep, the vim installation on the machine itself is apparently misconfigured 😵‍💫
rouven0 (Migrated from github.com) approved these changes 2023-09-17 17:08:35 +02:00
rouven0 (Migrated from github.com) left a comment
Copy link

Lgtm

Lgtm
hw0lff commented 2023-09-17 17:10:45 +02:00 (Migrated from github.com)
Copy link

It looks better now with that new formatting commit.
There where tabs in front of this block:
7ba1281909/modules/mail/default.nix (L203-L206)

I also aligned the contents of extraConfig.

It looks better now with that new formatting commit. There where tabs in front of this block: https://github.com/fsr/fruitbasket/blob/7ba1281909eb5ec160d386b3b6abbb9d0b264336/modules/mail/default.nix#L203-L206 I also aligned the contents of `extraConfig`.
Sign in to join this conversation.
Reviewers
No reviewers
rouven0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: wurzel/fruitbasket#66
No description provided.
Delete branch "mail-listescape"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?